Bug 169223

Summary: [Cocoa] Expose API::InjectedBundle::EditorClient::didChange via the Objective-C bundle SPI
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Add _webProcessPlugInBrowserContextControllerDidChange: thorton: review+

mitz
Reported 2017-03-06 15:05:44 PST
A WebKit client requires a bundle notification when the contents change due to editing.
Attachments
Add _webProcessPlugInBrowserContextControllerDidChange: (4.83 KB, patch)
2017-03-06 17:16 PST, mitz 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2017-03-06 17:16:11 PST
Created attachment 303588 [details] Add _webProcessPlugInBrowserContextControllerDidChange:
WebKit Commit Bot
Comment 2 2017-03-06 17:17:29 PST
Attachment 303588 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:626: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3 2017-03-06 17:17:55 PST
Comment on attachment 303588 [details] Add _webProcessPlugInBrowserContextControllerDidChange: View in context: https://bugs.webkit.org/attachment.cgi?id=303588&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInEditingDelegate.h:58 > +- (void)_webProcessPlugInBrowserContextControllerDidChange:(WKWebProcessPlugInBrowserContextController *)controller; I do not love this name.
mitz
Comment 4 2017-03-06 20:04:51 PST
Comment on attachment 303588 [details] Add _webProcessPlugInBrowserContextControllerDidChange: View in context: https://bugs.webkit.org/attachment.cgi?id=303588&action=review >> Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInEditingDelegate.h:58 >> +- (void)_webProcessPlugInBrowserContextControllerDidChange:(WKWebProcessPlugInBrowserContextController *)controller; > > I do not love this name. We are going to append “ByEditing”.
mitz
Comment 5 2017-03-06 21:15:45 PST
Committed <https://trac.webkit.org/r213498>.
Note You need to log in before you can comment on or make changes to this bug.