Bug 169220

Summary: webkitpy: Refactor setup_test_run for IOSPort and IOSSimulator
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, glenn, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 169054    
Attachments:
Description Flags
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2017-03-06 14:42:45 PST
IOSPort should hold the setup_test_run function for IOSSimulator. Rename current IOSSimulator.setup_test_run and call this function from IOSPort.
Attachments
Patch (2.17 KB, patch)
2017-03-06 14:48 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.30 KB, patch)
2017-03-07 11:26 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2017-03-06 14:48:18 PST
Created attachment 303562 [details] Patch
Radar WebKit Bug Importer
Comment 2 2017-03-06 14:49:24 PST
<rdar://problem/30879645>
Daniel Bates
Comment 3 2017-03-07 10:52:25 PST
Comment on attachment 303562 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303562&action=review > Tools/ChangeLog:7 > + Please explain the motivation for this change.
Daniel Bates
Comment 4 2017-03-07 10:53:11 PST
Comment on attachment 303562 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303562&action=review > Tools/ChangeLog:5 > + Please add the Radar bug URL here.
Jonathan Bedard
Comment 5 2017-03-07 11:26:00 PST
Created attachment 303684 [details] Patch for landing
WebKit Commit Bot
Comment 6 2017-03-07 12:05:54 PST
Comment on attachment 303684 [details] Patch for landing Clearing flags on attachment: 303684 Committed r213530: <http://trac.webkit.org/changeset/213530>
WebKit Commit Bot
Comment 7 2017-03-07 12:05:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.