Bug 169220 - webkitpy: Refactor setup_test_run for IOSPort and IOSSimulator
Summary: webkitpy: Refactor setup_test_run for IOSPort and IOSSimulator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks: 169054
  Show dependency tree / graph
 
Reported: 2017-03-06 14:42 PST by Jonathan Bedard
Modified: 2017-03-07 12:05 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.17 KB, patch)
2017-03-06 14:48 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (2.30 KB, patch)
2017-03-07 11:26 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2017-03-06 14:42:45 PST 
IOSPort should hold the setup_test_run function for IOSSimulator.  Rename current IOSSimulator.setup_test_run and call this function from IOSPort.
Comment 1 Jonathan Bedard 2017-03-06 14:48:18 PST 
Created attachment 303562 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2017-03-06 14:49:24 PST 
<rdar://problem/30879645>
Comment 3 Daniel Bates 2017-03-07 10:52:25 PST 
Comment on attachment 303562 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303562&action=review

> Tools/ChangeLog:7
> +

Please explain the motivation for this change.
Comment 4 Daniel Bates 2017-03-07 10:53:11 PST 
Comment on attachment 303562 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303562&action=review

> Tools/ChangeLog:5
> +

Please add the Radar bug URL here.
Comment 5 Jonathan Bedard 2017-03-07 11:26:00 PST 
Created attachment 303684 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2017-03-07 12:05:54 PST 
Comment on attachment 303684 [details]
Patch for landing

Clearing flags on attachment: 303684

Committed r213530: <http://trac.webkit.org/changeset/213530>
Comment 7 WebKit Commit Bot 2017-03-07 12:05:59 PST 
All reviewed patches have been landed.  Closing bug.