Bug 169211
| Summary: | REGRESSION(r213446): [GTK] Layout test fast/parser/adoption-agency-unload-iframe-4.html timeouts | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, kling, koivisto, lforschler, magomez, mcatanzaro, rniwa |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=172092 | ||
| Bug Depends on: | |||
| Bug Blocks: | 169079 | ||
Carlos Alberto Lopez Perez
The layout test fast/parser/adoption-agency-unload-iframe-4.html is timing out on platform GTK+ after r213446
I double checked r213446 <https://trac.webkit.org/changeset/213446> caused this:
* Built WebKitGTK+ r213445: The test works fine.
* Built WebKitGTK+ r213446: The test timeouts always (If I run it with --no-timeout hangs forever)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Alberto Lopez Perez
Test marked as timing out on https://trac.webkit.org/changeset/213462
Michael Catanzaro
Please leave a comment in bug #169079 so Antti knows something broke. If we don't tell people when their commits break things, that makes it much less likely that the bug is going to get fixed....
Carlos Alberto Lopez Perez
(In reply to comment #2)
> Please leave a comment in bug #169079 so Antti knows something broke. If we
> don't tell people when their commits break things, that makes it much less
> likely that the bug is going to get fixed....
I already added a "blocked by" dependency on the bug. Isn't that enough?
Carlos Alberto Lopez Perez
(In reply to comment #3)
> (In reply to comment #2)
> > Please leave a comment in bug #169079 so Antti knows something broke. If we
> > don't tell people when their commits break things, that makes it much less
> > likely that the bug is going to get fixed....
>
> I already added a "blocked by" dependency on the bug. Isn't that enough?
Also I cc'ed both the author and the reviewer of r213446
So I think I already did more than enough to notify Antti.
Miguel Gomez
This is passing reliably since r244212. Closing bug and updating expectations.
Radar WebKit Bug Importer
<rdar://problem/50424874>