Bug 169191

Summary: Only use layer backing store which supports subpixel antialiased text if we know subpixel antialiased will be painted into it
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, jonlee, simon.fraser, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
zalan: review+, buildbot: commit-queue-
Archive of layout-test-results from ews123 for ios-simulator-wk2 none

Simon Fraser (smfr)
Reported 2017-03-05 21:54:20 PST
Only use layer backing store which supports subpixel antialiased text if we know subpixel antialiased will be painted into it
Attachments
Patch (84.83 KB, patch)
2017-03-05 22:10 PST, Simon Fraser (smfr) 		zalan: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (881.30 KB, application/zip)
2017-03-05 23:32 PST, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2017-03-05 22:10:13 PST
Created attachment 303497 [details] Patch
Build Bot
Comment 2 2017-03-05 23:32:21 PST
Comment on attachment 303497 [details] Patch Attachment 303497 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3250669 New failing tests: compositing/contents-format/subpixel-antialiased-text-configs.html compositing/contents-format/subpixel-antialiased-text-visibility.html compositing/contents-format/subpixel-antialiased-text-enabled.html compositing/contents-format/subpixel-antialiased-text-images.html compositing/contents-format/subpixel-antialiased-text-configs-antialiasing-style.html
Build Bot
Comment 3 2017-03-05 23:32:24 PST
Created attachment 303500 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Radar WebKit Bug Importer
Comment 4 2017-03-06 00:08:28 PST
<rdar://problem/30864317>
alan
Comment 5 2017-03-06 11:11:19 PST
Comment on attachment 303497 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303497&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:2089 > +// Returning true stops the traversal. Out of date comment.
Sam Weinig
Comment 6 2017-03-06 11:15:42 PST
Comment on attachment 303497 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303497&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:848 > + logString.appendLiteral("texty"); "texty"? 🙄
Simon Fraser (smfr)
Comment 7 2017-03-06 13:46:31 PST
https://trac.webkit.org/r213466
Note You need to log in before you can comment on or make changes to this bug.