Bug 169181

Summary:

Web Inspector: Add settings for controlling Styles sidebar intelligence

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, inspector-bugzilla-changes, joepeck

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
[Image] After Patch is applied	none
Patch	timothy: review+
[Image] After Patch is applied	none
Patch	none

Devin Rousso

Reported 2017-03-05 02:43:25 PST

As discussed offline with Joe, it can be aggravating sometimes to click after the end of a CSS property in the styles sidebar and having a newline be automatically inserted. The same is true of the warning icons, especially for those who are well versed with CSS and understand what the strikethroughs can mean.

Attachments
Patch (14.78 KB, patch) 2017-03-05 02:50 PST, Devin Rousso	no flags	Details Formatted Diff Diff
[Image] After Patch is applied (92.35 KB, image/png) 2017-03-05 02:51 PST, Devin Rousso	no flags	Details
Patch (17.48 KB, patch) 2017-03-05 03:14 PST, Devin Rousso	timothy: review+	Details Formatted Diff Diff
[Image] After Patch is applied (92.21 KB, image/png) 2017-03-05 03:14 PST, Devin Rousso	no flags	Details
Patch (18.40 KB, patch) 2017-03-08 15:47 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2017-03-05 02:50:51 PST

Created attachment 303449 [details] Patch

Devin Rousso

Comment 2 2017-03-05 02:51:12 PST

Created attachment 303450 [details] [Image] After Patch is applied

Devin Rousso

Comment 3 2017-03-05 03:14:24 PST

Created attachment 303451 [details] Patch

Devin Rousso

Comment 4 2017-03-05 03:14:54 PST

Created attachment 303452 [details] [Image] After Patch is applied Had to rework a small spacing issue :D

Joseph Pecoraro

Comment 5 2017-03-06 11:31:14 PST

Interesting! We may need to move to multiple columns in the Settings pane, its starting to get longer. I haven't yet reviewed the patch, I want to try it. We don't want to go overboard with settings so I'd like to see what others think (and myself after I try it).

Timothy Hatcher

Comment 6 2017-03-08 09:45:19 PST

Comment on attachment 303451 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303451&action=review > Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:129 > +localizedStrings["CSS Editing:"] = "CSS Editing:"; The sidebar is "Styles" or "Rules", we don't use CSS in the UI. > Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:717 > +localizedStrings["Show warning icons"] = "Show warning icons"; "Show inline warnings". The fact that is an icon is an implementation detail.

Devin Rousso

Comment 7 2017-03-08 15:47:19 PST

Created attachment 303854 [details] Patch So I reworked the "Select text on first click" option to work more like how Chrome/Firefox currently function, meaning that it will always select the text range only on the first click.

WebKit Commit Bot

Comment 8 2017-03-09 02:51:40 PST

Comment on attachment 303854 [details] Patch Clearing flags on attachment: 303854 Committed r213635: <http://trac.webkit.org/changeset/213635>

WebKit Commit Bot

Comment 9 2017-03-09 02:51:45 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.