Bug 169171 – Perf and layout test results should report using correct scm revision

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Kocsen Chung]

Perf test and layout test results should report using the correct scm native       revision as an identifier; for more accurate record keeping.

[Kocsen Chung]

Created attachment 303399 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 303399 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303399&action=review

> Tools/Scripts/webkitpy/common/checkout/scm/git.py:279
> +        # If `revision` is composed of 0-6 digits, assume SVN revision. Else, assume git hash
> +        svn_revision_regex = re.compile('^[1-9]\d{0,5}$')

This is a rather dangerous assumption. A git hash especially not the full length one could entirely consist of digits.

> Tools/Scripts/webkitpy/common/checkout/scm/git.py:-289
>      def timestamp_of_revision(self, path, revision):
> -        git_log = self._most_recent_log_matching('git-svn-id:.*@%s' % revision, path)

I think it's better to add a new version of this function which gets the timestamp for the "native" revision.

> Tools/Scripts/webkitpy/common/checkout/scm/scm.py:72
> +                                           cwd=cwd,

Nit: This is wrong indentation.
Per WebKit's style guideline, these text should be exactly 4 spaces on the right of the beginning of "return self._executive..."

[Kocsen Chung]

Created attachment 303669 [details]
Patch

[Kocsen Chung]

Take 2: incorporating Ryosuke's comments.

[WebKit Commit Bot]

Comment on attachment 303669 [details]
Patch

Clearing flags on attachment: 303669

Committed r213562: <http://trac.webkit.org/changeset/213562>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.