Bug 169148

Summary: [MediaStream iOS] REGRESSION(r212883): Missing function definition breaks sandbox
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, eric.carlson, jonlee, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 168756    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch achristensen: review+

Brent Fulgham
Reported 2017-03-03 14:06:27 PST
The changes in <https://trac.webkit.org/changeset/212883> add a new call to 'shared-preferences-read'. Unfortunately, 'shared-preferences-read' is a custom function defined in com.apple.WebKit.WebContent.sb.in, but not the iOS-specific com.apple.WebKit.WebContent.sb file. This causes the sandbox to fail to parse.
Attachments
Patch (2.26 KB, patch)
2017-03-03 14:14 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (1.68 KB, patch)
2017-03-03 16:15 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (1.68 KB, patch)
2017-03-03 16:15 PST, Brent Fulgham 		achristensen: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2017-03-03 14:12:09 PST
<rdar://problem/30825728>
Brent Fulgham
Comment 2 2017-03-03 14:14:17 PST
Created attachment 303341 [details] Patch
Alexey Proskuryakov
Comment 3 2017-03-03 14:52:06 PST
Comment on attachment 303341 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303341&action=review > Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:116 > + (literal (string-append "/Library/Preferences/" domain ".plist")) Is this where preferences live on iOS? Perhaps we don't need this fallback path at all, and just rely on user-preference-read. It may be best to just use user-preference-read instead of defining a function. > Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:117 > + (home-library-preferences-literal (string-append "/" domain ".plist")) Wouldn't we need to define this function too?
Brent Fulgham
Comment 4 2017-03-03 16:15:19 PST
Created attachment 303352 [details] Patch
Brent Fulgham
Comment 5 2017-03-03 16:15:50 PST
Created attachment 303353 [details] Patch
Brent Fulgham
Comment 6 2017-03-03 16:33:41 PST
Committed r213394: <http://trac.webkit.org/changeset/213394>
Note You need to log in before you can comment on or make changes to this bug.