Bug 169137

Summary: [iOS] Throttle SVG SMIL animations to 30fps in low power mode
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: SVGAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, jonlee, sabouhallawa, simon.fraser, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2017-03-03 09:40:45 PST
Throttle SVG SMIL animations to 30fps in low power mode on iOS to save battery.
Attachments
Patch (14.30 KB, patch)
2017-03-03 11:48 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-03-03 09:41:22 PST
<rdar://problem/30833754>
Chris Dumez
Comment 2 2017-03-03 11:48:47 PST
Created attachment 303331 [details] Patch
Simon Fraser (smfr)
Comment 3 2017-03-03 12:07:26 PST
Comment on attachment 303331 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303331&action=review > Source/WebCore/svg/animation/SMILTimeContainer.cpp:39 > +static const Seconds SMILAnimationFrameDelay { 1.0 / 60 }; > +static const Seconds SMILAnimationFrameThrottledDelay { 1.0 / 30 }; Not sure why these aren't slightly less than these values, as we do for CSS and timer-based rAF.
Chris Dumez
Comment 4 2017-03-03 12:10:03 PST
Comment on attachment 303331 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303331&action=review >> Source/WebCore/svg/animation/SMILTimeContainer.cpp:39 >> +static const Seconds SMILAnimationFrameThrottledDelay { 1.0 / 30 }; > > Not sure why these aren't slightly less than these values, as we do for CSS and timer-based rAF. Would you like me to align the values in this patch?
WebKit Commit Bot
Comment 5 2017-03-03 15:53:43 PST
Comment on attachment 303331 [details] Patch Clearing flags on attachment: 303331 Committed r213393: <http://trac.webkit.org/changeset/213393>
WebKit Commit Bot
Comment 6 2017-03-03 15:53:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.