Bug 169136

Summary:

We should only check for traps that we're able to handle.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, keith_miller, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	msaboff: review+

Description Mark Lam 2017-03-03 09:19:07 PST

The execute methods in interpreter were checking for the existence of any traps (without masking) and only handling a subset of those via a mask.  This can result in a failed assertion on debug builds.

Comment 1 Mark Lam 2017-03-03 09:25:42 PST

Created attachment 303326 [details]
proposed patch.

Comment 2 Michael Saboff 2017-03-03 09:32:03 PST

Comment on attachment 303326 [details]
proposed patch.

r=me

Comment 3 Mark Lam 2017-03-03 09:48:13 PST

Thanks for the review.  Landed in r213367: <http://trac.webkit.org/r213367>.