Bug 169126

Summary:

[GTK] Two file reset tests are failing in the bots since they were added in r213042

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, bugs-noreply, commit-queue, lforschler, thorton

Priority:

Keywords:

Gtk, LayoutTestFailure

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Carlos Garcia Campos

Reported 2017-03-03 02:57:23 PST

They are failing because the GTK+ event sender is not firing the second UIHelper.activateAt() after the change event. In onse case this causes that the reset button is not locked, and in the other one the file input is not unfocused. https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r213357%20(21247)/fast/forms/file/file-input-reset-using-open-panel-diffs.html https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r213357%20(21247)/fast/forms/file/file-reset-in-change-using-open-panel-diffs.html This is because the change event is emitted before the mouse up, and the GTK+ event sender ignores mouse down events when the button is already down to not confuse Xvfb. So, we can easily fix theses tests by using a timeout to ensure the next UIHelper.activateAt() happens in a different run loop iteration, after the mouse up.

Attachments
Patch (3.75 KB, patch) 2017-03-03 02:59 PST, Carlos Garcia Campos	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Carlos Garcia Campos

Comment 1 2017-03-03 02:59:51 PST

WebKit Commit Bot

Comment 2 2017-03-05 03:10:13 PST

WebKit Commit Bot

Comment 3 2017-03-05 03:10:19 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.