Bug 169108

Summary: [iOS] Enable webrtc tests for debug builds
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jonlee, ryanhaddad, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for landing none

youenn fablet
Reported 2017-03-02 16:26:15 PST
[iOS] Enable webrtc tests for debug builds
Attachments
Patch for landing (2.00 KB, patch)
2017-03-02 16:28 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-03-02 16:28:58 PST
Created attachment 303268 [details] Patch for landing
WebKit Commit Bot
Comment 2 2017-03-02 16:31:21 PST
Attachment 303268 [details] did not pass style-queue: ERROR: LayoutTests/ChangeLog:8: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2017-03-02 17:33:49 PST
Comment on attachment 303268 [details] Patch for landing Clearing flags on attachment: 303268 Committed r213332: <http://trac.webkit.org/changeset/213332>
WebKit Commit Bot
Comment 4 2017-03-02 17:33:52 PST
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 5 2017-03-02 19:52:02 PST
It appears that the tests are failing or timing out on ios-simulator debug: https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Debug%20WK2%20(Tests)/builds/3939
Ryan Haddad
Comment 6 2017-03-02 19:57:59 PST
Reverted r213332 for reason: These tests are failing on ios-simulator debug. Committed r213343: <http://trac.webkit.org/changeset/213343>
Radar WebKit Bug Importer
Comment 7 2017-08-29 09:49:58 PDT
<rdar://problem/34134403>
Jon Lee
Comment 8 2017-08-29 15:43:17 PDT
Is there anything left to do here?
youenn fablet
Comment 9 2017-09-28 11:35:11 PDT
Closing bug as tests have beeb improved and expectations updated in other patches
Note You need to log in before you can comment on or make changes to this bug.