| Summary: | Modernize ContentExtensionParser | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | ||||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2017-03-02 15:51:33 PST
Created attachment 303262 [details]
Patch
Comment on attachment 303262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303262&action=review > Source/WebCore/contentextensions/ContentExtensionParser.cpp:67 > - ASSERT(vector.isEmpty()); > + Vector<String> domains; I'd declare this farther down, before the for loop. > Source/WebCore/contentextensions/ContentExtensionParser.cpp:86 > + return domains; The NRVO won't apply here, so you should WTFMove() domains. > Source/WebCore/contentextensions/ContentExtensionParser.cpp:188 > + return trigger; Ditto. > Source/WebCore/contentextensions/ContentExtensionParser.cpp:299 > + return ruleList; Ditto. > Source/WebCore/contentextensions/ContentExtensionParser.cpp:328 > + return ruleList; Ditto. |