Bug 169102

Summary: Update WKWebsiteDatastoreConfiguration SPI
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Brady Eidson
Reported 2017-03-02 15:31:34 PST
Update WKWebsiteDatastoreConfiguration SPI Based on late review feedback to the initial patch.
Attachments
Patch (10.13 KB, patch)
2017-03-02 15:33 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (10.14 KB, patch)
2017-03-02 15:41 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2017-03-02 15:33:44 PST
Created attachment 303255 [details] Patch
Tim Horton
Comment 2 2017-03-02 15:36:31 PST
Comment on attachment 303255 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303255&action=review > Source/WebKit2/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm:51 > + _webStorageDirectoryURL = [url copy]; You need a whole bunch of adopts!
Brady Eidson
Comment 3 2017-03-02 15:41:27 PST
Created attachment 303259 [details] Patch
Brady Eidson
Comment 4 2017-03-02 15:41:51 PST
Waiting for EWS then will CQ+
WebKit Commit Bot
Comment 5 2017-03-02 17:33:28 PST
Comment on attachment 303259 [details] Patch Clearing flags on attachment: 303259 Committed r213331: <http://trac.webkit.org/changeset/213331>
WebKit Commit Bot
Comment 6 2017-03-02 17:33:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.