Bug 169100

Summary: flex-basis should be 0% (not 0px) when omitted from flex shorthand
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: CSSAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: ryanhaddad
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dino: review+

Dave Hyatt
Reported 2017-03-02 14:25:33 PST
flex-basis should be 0% (not 0px) when omitted from flex shorthand
Attachments
Patch (10.54 KB, patch)
2017-03-02 14:29 PST, Dave Hyatt 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2017-03-02 14:26:32 PST
rdar://problem/30796872
Dave Hyatt
Comment 2 2017-03-02 14:29:32 PST
Created attachment 303242 [details] Patch
Dave Hyatt
Comment 3 2017-03-02 14:37:11 PST
Fixed in r213305.
Ryan Haddad
Comment 4 2017-03-02 15:36:11 PST
This change caused fast/css/flex-calculated-value.html to fail. I assume this test should have been updated too? https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK1%20(Tests)/r213308%20(14227)/results.html
Ryan Haddad
Comment 5 2017-03-02 15:56:46 PST
I updated the test in http://trac.webkit.org/projects/webkit/changeset/213315. EWS would have caught this had it been allowed to finish.
Note You need to log in before you can comment on or make changes to this bug.