Bug 169088

Summary:

Add Options::alwaysCheckTraps() and Options::usePollingTraps() options.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

fpizlo, ggaren, jfbastien, keith_miller, msaboff, saam

Priority:

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

168920

Attachments:

Description	Flags
proposed patch.	mark.lam: review-
proposed patch.	none
proposed patch.	keith_miller: review+

Mark Lam

Reported 2017-03-02 12:15:39 PST

This enables the use of polling VM traps all the time. This will be useful for benchmark comparisons, as well as for forcing polling traps later for ports that don't support signal based traps.

Attachments
proposed patch. (6.69 KB, patch) 2017-03-02 12:51 PST, Mark Lam	mark.lam: review-	Details Formatted Diff Diff
proposed patch. (8.13 KB, patch) 2017-03-02 13:32 PST, Mark Lam	no flags	Details Formatted Diff Diff
proposed patch. (8.15 KB, patch) 2017-03-02 13:49 PST, Mark Lam	keith_miller: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Mark Lam

Comment 1 2017-03-02 12:51:52 PST

Created attachment 303226 [details] proposed patch.

Mark Lam

Comment 2 2017-03-02 13:32:05 PST

Created attachment 303229 [details] proposed patch.

Mark Lam

Comment 3 2017-03-02 13:49:43 PST

Created attachment 303233 [details] proposed patch.

Keith Miller

Comment 4 2017-03-02 13:50:14 PST

Comment on attachment 303233 [details] proposed patch. r=me.

Mark Lam

Comment 5 2017-03-02 14:05:37 PST

Thanks for the review. Landed in r213302: <http://trac.webkit.org/r213302>.

Note You need to log in before you can comment on or make changes to this bug.