Bug 169079 – Allow render tree building before loading stylesheet elements

• Component: CSS
• Status: RESOLVED FIXED

[Antti Koivisto]

Don't block style resolve and render tree building completely when stylesheet are loading.

[Antti Koivisto]

Created attachment 303193 [details]
wip

[Build Bot]

Comment on attachment 303193 [details]
wip

Attachment 303193 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3222136

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 303195 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 303193 [details]
wip

Attachment 303193 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3222135

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 303196 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 303193 [details]
wip

Attachment 303193 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3222129

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 303197 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 303193 [details]
wip

Attachment 303193 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3222139

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 303198 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Antti Koivisto]

Created attachment 303201 [details]
wip

[Antti Koivisto]

Created attachment 303202 [details]
wip

[Build Bot]

Comment on attachment 303202 [details]
wip

Attachment 303202 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3222750

New failing tests:
svg/as-image/img-zoom-svg-stylesheet.html
fast/parser/adoption-agency-unload-iframe-4.html

[Build Bot]

Created attachment 303205 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 303202 [details]
wip

Attachment 303202 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3222767

New failing tests:
svg/as-image/img-zoom-svg-stylesheet.html
fast/parser/adoption-agency-unload-iframe-4.html

[Build Bot]

Created attachment 303206 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 303202 [details]
wip

Attachment 303202 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3222770

New failing tests:
svg/as-image/img-zoom-svg-stylesheet.html
fast/parser/adoption-agency-unload-iframe-4.html

[Build Bot]

Created attachment 303208 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 303202 [details]
wip

Attachment 303202 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3222759

New failing tests:
svg/as-image/img-zoom-svg-stylesheet.html

[Build Bot]

Created attachment 303210 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Antti Koivisto]

Created attachment 303333 [details]
wip

[Antti Koivisto]

Created attachment 303502 [details]
patch

[Radar WebKit Bug Importer]

<rdar://problem/30865709>

[Andreas Kling]

Comment on attachment 303502 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303502&action=review

r=me

> Source/WebCore/style/StyleScope.h:155
> -    int m_pendingStyleSheetCount { 0 };
> +    HashSet<const Node*> m_nodesWithPendingSheets;

It would be nice to have some assertion that nodes actually get disappeared from this set in an orderly fashion.

[Antti Koivisto]

Created attachment 303506 [details]
patch

[Build Bot]

Comment on attachment 303506 [details]
patch

Attachment 303506 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3251588

New failing tests:
media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html

[Build Bot]

Created attachment 303507 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[WebKit Commit Bot]

Comment on attachment 303506 [details]
patch

Clearing flags on attachment: 303506

Committed r213446: <http://trac.webkit.org/changeset/213446>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.