Bug 169069

Summary: Make baseline data points selectable
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Perf DashboardAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, cdumez, dewei_zhu, kling, koivisto, krollin, rniwa, slewis
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Adds the feature koivisto: review+

Ryosuke Niwa
Reported 2017-03-01 21:05:19 PST
Make baseline data points on the perf dashboard selectable
Attachments
Adds the feature (103.27 KB, patch)
2017-03-02 01:23 PST, Ryosuke Niwa 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-03-01 23:50:50 PST
<rdar://problem/29209427>
Ryosuke Niwa
Comment 2 2017-03-02 01:23:46 PST
Created attachment 303179 [details] Adds the feature
Antti Koivisto
Comment 3 2017-03-02 03:00:40 PST
Comment on attachment 303179 [details] Adds the feature View in context: https://bugs.webkit.org/attachment.cgi?id=303179&action=review > Websites/perf.webkit.org/ChangeLog:16 > + to know whenever these values changed. Because of this entangled, ChartStatusView had to be aware of "Because of this entanglement" > Websites/perf.webkit.org/ChangeLog:19 > + This patch dramatically simplifies the siuation by adding referencePoints() on TimeSeriesChart and "situation" > Websites/perf.webkit.org/ChangeLog:29 > + memoizes the return value of a function when called with the same arguments. Delaying the computation of "memoize"
Ryosuke Niwa
Comment 4 2017-03-02 13:22:01 PST
Committed r213300: <http://trac.webkit.org/changeset/213300>
Note You need to log in before you can comment on or make changes to this bug.