Bug 169056

Summary: Continue enabling WebRTC
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jonlee, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch jonlee: review+

Alex Christensen
Reported 2017-03-01 14:14:03 PST
Continue enabling WebRTC
Attachments
Patch (10.42 KB, patch)
2017-03-01 14:28 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (10.35 KB, patch)
2017-03-01 14:31 PST, Alex Christensen 		jonlee: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-03-01 14:28:26 PST
Created attachment 303117 [details] Patch
WebKit Commit Bot
Comment 2 2017-03-01 14:30:11 PST
Attachment 303117 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 3 2017-03-01 14:31:59 PST
Created attachment 303118 [details] Patch
Alex Christensen
Comment 4 2017-03-01 19:57:51 PST
http://trac.webkit.org/r213259
Alex Christensen
Comment 5 2017-03-01 20:33:46 PST
And out again in http://trac.webkit.org/r213260
Alex Christensen
Comment 6 2017-03-02 12:18:41 PST
http://trac.webkit.org/r213294
Note You need to log in before you can comment on or make changes to this bug.