Summary: | Web Inspector: Option-clicking the close tab button should close all other tabs | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, commit-queue, hi, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
BJ Burg
2017-03-01 11:04:45 PST
Devin, want to knock this out? Created attachment 305517 [details]
Patch
Comment on attachment 305517 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305517&action=review r=me > Source/WebInspectorUI/UserInterface/Views/TabBar.js:617 > + if (event.altKey) { Suggested early return: if (!event.altKey) { this.removeTabBarItem(tabBarItem, false, true); return; } Created attachment 305562 [details]
Patch
Comment on attachment 305562 [details] Patch Clearing flags on attachment: 305562 Committed r214464: <http://trac.webkit.org/changeset/214464> All reviewed patches have been landed. Closing bug. Is this really what we want? I can see how it is useful in Safari / Web Browser but in Web Inspector I suspect this would only be triggered accidentally / unexpectedly. |