Bug 169043

Summary: Move declaration of _WKSetCrashReportApplicationSpecificInformation to header file
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: WebKit2Assignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, juergen, mitz, thorton
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
none
Updated patch none

Aakash Jain
Reported 2017-03-01 10:17:04 PST
This symbols from WebProcess/cocoa/WebProcessCocoa.mm is not used by anyone outside WebKit2. Headers doesn't have this symbol. We should try to match the headers and library.
Attachments
Proposed patch (1.24 KB, patch)
2017-03-01 10:17 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Updated patch (7.76 KB, patch)
2017-03-02 18:56 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2017-03-01 10:17:55 PST
Created attachment 303077 [details] Proposed patch
Aakash Jain
Comment 2 2017-03-01 10:23:59 PST
Seems like this symbol is required and was added recently in https://bugs.webkit.org/show_bug.cgi?id=168739
Aakash Jain
Comment 3 2017-03-02 18:56:54 PST
Created attachment 303288 [details] Updated patch
WebKit Commit Bot
Comment 4 2017-03-02 18:59:46 PST
Attachment 303288 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:28: Found header this file implements after a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 5 2017-03-02 21:34:58 PST
Comment on attachment 303288 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=303288&action=review > Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:451 > // FIXME: This should live somewhere else, and it should have the implementation in line instead of calling out to WKSI. This comment should be removed.
Alex Christensen
Comment 6 2017-03-02 21:35:37 PST
Comment on attachment 303288 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=303288&action=review >> Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:451 >> // FIXME: This should live somewhere else, and it should have the implementation in line instead of calling out to WKSI. > > This comment should be removed. Just kidding. This comment should stay.
WebKit Commit Bot
Comment 7 2017-03-03 13:37:34 PST
Comment on attachment 303288 [details] Updated patch Clearing flags on attachment: 303288 Committed r213383: <http://trac.webkit.org/changeset/213383>
WebKit Commit Bot
Comment 8 2017-03-03 13:37:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.