Bug 169035

Summary: [WTF] va_list is not ended in StringPrintStream
Product: WebKit Reporter: Tomas Popela <tpopela>
Component: Web Template FrameworkAssignee: Tomas Popela <tpopela>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 104114    
Attachments:
Description Flags
Patch none

Tomas Popela
Reported 2017-03-01 06:08:32 PST
Detected by Coverity scan: 1. webkitgtk-2.14.5/Source/WTF/wtf/StringPrintStream.cpp:57: va_init: Initializing va_list "firstPassArgList". 4. webkitgtk-2.14.5/Source/WTF/wtf/StringPrintStream.cpp:83: missing_va_end: va_end was not called for "firstPassArgList". # 81| ASSERT_WITH_SECURITY_IMPLICATION(m_next < m_size); # 82| ASSERT(!m_buffer[m_next]); # 83|-> } # 84| # 85| CString StringPrintStream::toCString()
Attachments
Patch (3.26 KB, patch)
2017-03-01 06:12 PST, Tomas Popela 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tomas Popela
Comment 1 2017-03-01 06:12:18 PST
Created attachment 303065 [details] Patch
Michael Saboff
Comment 2 2017-03-01 07:37:26 PST
Comment on attachment 303065 [details] Patch r=me
Tomas Popela
Comment 3 2017-03-01 07:45:52 PST
Comment on attachment 303065 [details] Patch Clearing flags on attachment: 303065 Committed r213223: <http://trac.webkit.org/changeset/213223>
Tomas Popela
Comment 4 2017-03-01 07:46:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.