Bug 169034

Summary:

Incorrect RELEASE_ASSERT in JSGlobalObject::addStaticGlobals()

Product:

WebKit

Reporter:

Tomas Popela <tpopela>

Component:

JavaScriptCore

Assignee:

Tomas Popela <tpopela>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, keith_miller, mark.lam, mcatanzaro, msaboff, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

104114

Attachments:

Description	Flags
Patch	none

Description Tomas Popela 2017-03-01 06:02:55 PST

There is an incorrect RELEASE_ASSERT in JSGlobalObject::addStaticGlobals(GlobalPropertyInfo* globals, int count):

RELEASE_ASSERT(offset = startOffset + i);

it should not assign to offset, but compare to offset.

Comment 1 Tomas Popela 2017-03-01 06:04:38 PST

Created attachment 303064 [details]
Patch

Comment 2 Mark Lam 2017-03-01 09:49:23 PST

Comment on attachment 303064 [details]
Patch

r=me

Comment 3 Tomas Popela 2017-03-02 01:42:18 PST

Comment on attachment 303064 [details]
Patch

Clearing flags on attachment: 303064

Committed r213275: <http://trac.webkit.org/changeset/213275>

Comment 4 Tomas Popela 2017-03-02 01:42:26 PST

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2017-03-10 12:09:35 PST

<rdar://problem/30978527>