Bug 169034

Summary: Incorrect RELEASE_ASSERT in JSGlobalObject::addStaticGlobals()
Product: WebKit Reporter: Tomas Popela <tpopela>
Component: JavaScriptCoreAssignee: Tomas Popela <tpopela>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, mcatanzaro, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 104114    
Attachments:
Description Flags
Patch none

Tomas Popela
Reported 2017-03-01 06:02:55 PST
There is an incorrect RELEASE_ASSERT in JSGlobalObject::addStaticGlobals(GlobalPropertyInfo* globals, int count): RELEASE_ASSERT(offset = startOffset + i); it should not assign to offset, but compare to offset.
Attachments
Patch (1.64 KB, patch)
2017-03-01 06:04 PST, Tomas Popela 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tomas Popela
Comment 1 2017-03-01 06:04:38 PST
Created attachment 303064 [details] Patch
Mark Lam
Comment 2 2017-03-01 09:49:23 PST
Comment on attachment 303064 [details] Patch r=me
Tomas Popela
Comment 3 2017-03-02 01:42:18 PST
Comment on attachment 303064 [details] Patch Clearing flags on attachment: 303064 Committed r213275: <http://trac.webkit.org/changeset/213275>
Tomas Popela
Comment 4 2017-03-02 01:42:26 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-03-10 12:09:35 PST
<rdar://problem/30978527>
Note You need to log in before you can comment on or make changes to this bug.