Summary: | [GTK] Fix problems found by Coverity scan in platform's keyboard and mouse events | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tomas Popela <tpopela> | ||||
Component: | WebKitGTK | Assignee: | Tomas Popela <tpopela> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bugs-noreply, mcatanzaro | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 104114 | ||||||
Attachments: |
|
Description
Tomas Popela
2017-03-01 03:50:38 PST
Created attachment 303060 [details]
Patch
Comment on attachment 303060 [details] Patch Clearing flags on attachment: 303060 Committed r213218: <http://trac.webkit.org/changeset/213218> All reviewed patches have been landed. Closing bug. The original commit introduced a compiler error that I fixed in http://trac.webkit.org/changeset/213220: [8/67] Building CXX object Source/WebCore/CMakeFiles/WebCorePlatformGTK2.dir/platform/gtk/PlatformKeyboardEventGtk.cpp.o In file included from ../../Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp:31:0: ../../Source/WebCore/platform/PlatformKeyboardEvent.h: In constructor ‘WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent(GdkEventKey*, const WebCore::CompositionResults&)’: ../../Source/WebCore/platform/PlatformKeyboardEvent.h:186:14: warning: ‘WebCore::PlatformKeyboardEvent::m_autoRepeat’ will be initialized after [-Wreorder] bool m_autoRepeat; ^~~~~~~~~~~~ ../../Source/WebCore/platform/PlatformKeyboardEvent.h:179:14: warning: ‘bool WebCore::PlatformKeyboardEvent::m_handledByInputMethod’ [-Wreorder] bool m_handledByInputMethod; ^~~~~~~~~~~~~~~~~~~~~~ ../../Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp:1261:1: warning: when initialized here [-Wreorder] PlatformKeyboardEvent::PlatformKeyboardEvent(GdkEventKey* event, const CompositionResults& compositionResults) ^~~~~~~~~~~~~~~~~~~~~ |