Bug 168998

Summary: font shorthand should accept variation values
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: TextAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, jonlee, mmaxfield, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 162815    
Attachments:
Description Flags
WIP
none
Patch simon.fraser: review+

Myles C. Maxfield
Reported 2017-02-28 15:49:19 PST
font shorthand should accept font-stretch values
Attachments
WIP (11.32 KB, patch)
2017-03-20 15:07 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (18.10 KB, patch)
2017-03-20 16:07 PDT, Myles C. Maxfield 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2017-02-28 23:00:21 PST
See also https://github.com/w3c/csswg-drafts/issues/515
Myles C. Maxfield
Comment 2 2017-03-20 09:27:14 PDT
Simply removing consumeFontWeightCSS21() causes these tests to fail: +fast/parser/style-script-head-test.html expected actual diff pretty diff images diff (0.62%) text image+text pass history +fast/text/font-weight-parse.html expected actual diff pretty diff text pass history +fast/text/simple-line-layout-innerText-with-newline.html reference images diff (0.03%) image pass history +http/tests/misc/acid3.html expected actual diff pretty diff images diff (2.67%) text image+text pass history
Myles C. Maxfield
Comment 3 2017-03-20 15:07:32 PDT
Created attachment 304955 [details] WIP
Myles C. Maxfield
Comment 4 2017-03-20 16:07:22 PDT
Created attachment 304961 [details] Patch
Simon Fraser (smfr)
Comment 5 2017-03-22 15:54:42 PDT
Comment on attachment 304961 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304961&action=review > Source/WebCore/ChangeLog:12 > + accepts percentages, which are also accepted by font-size, which means those can't "those" here is ambiguous. > Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:202 > + // Values less than or equal to 0 or greater than or equal to 1000 are parse errors. Is this covered in the testing?
Myles C. Maxfield
Comment 6 2017-03-23 16:14:07 PDT
Committed r214324: <http://trac.webkit.org/changeset/214324>
Note You need to log in before you can comment on or make changes to this bug.