Bug 168990

Summary:

[WebRTC] CPU Overuse libwebrtc detector is decreasing the quality of the video

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue, eric.carlson

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

youenn fablet

Reported 2017-02-28 14:23:00 PST

For now, we can just disable it. We should at the end investigate the different strategies in that case.

Attachments
Patch (1.80 KB, patch) 2017-02-28 14:25 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (1.75 KB, patch) 2017-02-28 15:09 PST, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2017-02-28 14:25:08 PST

Created attachment 302986 [details] Patch

Eric Carlson

Comment 2 2017-02-28 14:50:29 PST

Comment on attachment 302986 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302986&action=review > Source/ThirdParty/libwebrtc/ChangeLog:4 > + Fix 168990 > + Nit: this isn't necessary. > Source/ThirdParty/libwebrtc/Source/webrtc/video/vie_encoder.cc:791 > + //WEBKIT Change: We disable OveruseDetected for now. Nit: space after the "//"

youenn fablet

Comment 3 2017-02-28 15:09:27 PST

Created attachment 302994 [details] Patch for landing

youenn fablet

Comment 4 2017-02-28 15:09:57 PST

Thanks for the review. (In reply to comment #2) > Comment on attachment 302986 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=302986&action=review > > > Source/ThirdParty/libwebrtc/ChangeLog:4 > > + Fix 168990 > > + > > Nit: this isn't necessary. OK > > Source/ThirdParty/libwebrtc/Source/webrtc/video/vie_encoder.cc:791 > > + //WEBKIT Change: We disable OveruseDetected for now. > > Nit: space after the "//" Done

WebKit Commit Bot

Comment 5 2017-02-28 15:24:24 PST

Comment on attachment 302994 [details] Patch for landing Clearing flags on attachment: 302994 Committed r213184: <http://trac.webkit.org/changeset/213184>

WebKit Commit Bot

Comment 6 2017-02-28 15:24:29 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.