Bug 168986

Summary: LibWebRTCProvider should check existence of libwebrtc.dylib
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2017-02-28 13:36:17 PST
LibWebRTCProvider should check existence of libwebrtc.dylib
Attachments
Patch (14.18 KB, patch)
2017-02-28 13:40 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (14.00 KB, patch)
2017-02-28 15:01 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (14.62 KB, patch)
2017-02-28 15:11 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (15.17 KB, patch)
2017-02-28 15:19 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-02-28 13:40:52 PST
Created attachment 302975 [details] Patch
youenn fablet
Comment 2 2017-02-28 14:14:15 PST
Comment on attachment 302975 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302975&action=review > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:160 > + if (senders.size() && LibWebRTCProvider::factory()) { If we do not have a factory, it might be better to just reject the promise upfront. Typically by calling createOfferFailed from m_peerConnectionBackend.
Alex Christensen
Comment 3 2017-02-28 15:01:23 PST
Created attachment 302991 [details] Patch
Alex Christensen
Comment 4 2017-02-28 15:11:10 PST
Created attachment 302995 [details] Patch
Alex Christensen
Comment 5 2017-02-28 15:19:57 PST
Created attachment 302996 [details] Patch
Alex Christensen
Comment 6 2017-02-28 16:09:27 PST
http://trac.webkit.org/r213190
Note You need to log in before you can comment on or make changes to this bug.