Bug 168979

Summary: Add ability for webkitpy to run bindings tests
Product: WebKit Reporter: Srinivasan Vijayaraghavan <webkit>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, glenn, webkit
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=169308
https://bugs.webkit.org/show_bug.cgi?id=169307
Attachments:
Description Flags
Patch
none
Patch none

Srinivasan Vijayaraghavan
Reported 2017-02-28 11:30:58 PST
Add ability for webkitpy to run bindings tests
Attachments
Patch (3.40 KB, patch)
2017-02-28 11:35 PST, Srinivasan Vijayaraghavan 		no flags
DetailsFormatted DiffDiff
Patch (4.82 KB, patch)
2017-02-28 13:57 PST, Srinivasan Vijayaraghavan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Srinivasan Vijayaraghavan
Comment 1 2017-02-28 11:35:26 PST
Created attachment 302955 [details] Patch
Aakash Jain
Comment 2 2017-02-28 12:05:05 PST
Comment on attachment 302955 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302955&action=review looks good to me. > Tools/Scripts/webkitpy/tool/steps/runtests.py:168 > + self._tool.filesystem.maybe_make_directory(results_directory) do we need similar line in _run_javascriptcore_tests as well above.
Srinivasan Vijayaraghavan
Comment 3 2017-02-28 13:06:52 PST
(In reply to comment #2) > Comment on attachment 302955 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=302955&action=review > > looks good to me. > > > Tools/Scripts/webkitpy/tool/steps/runtests.py:168 > > + self._tool.filesystem.maybe_make_directory(results_directory) > > do we need similar line in _run_javascriptcore_tests as well above. JSC tests cannot run without building, so if the WebKitBuild/[Release/Debug] directory doesn't exist at the time of writing the test results to a file, something would have gone very wrong. Adding the line enables some code to be abstracted out, but I'd prefer to not abstract things out until we have another group of tests. Some things, like the results directory, might change by then. Placing results inside WebKitBuild/ for consistency is OK, but it might make sense to move as we add more tests that don't require a build to run (bindings is one of them, also webkitpy, webkitperl etc).
Srinivasan Vijayaraghavan
Comment 4 2017-02-28 13:57:27 PST
Created attachment 302982 [details] Patch
Srinivasan Vijayaraghavan
Comment 5 2017-02-28 13:57:45 PST
Added a unit test.
Aakash Jain
Comment 6 2017-02-28 14:10:59 PST
looks good to me.
WebKit Commit Bot
Comment 7 2017-02-28 15:26:35 PST
Comment on attachment 302982 [details] Patch Clearing flags on attachment: 302982 Committed r213185: <http://trac.webkit.org/changeset/213185>
WebKit Commit Bot
Comment 8 2017-02-28 15:26:40 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.