| Summary: | Add ability for webkitpy to run bindings tests | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Srinivasan Vijayaraghavan <webkit> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, ap, commit-queue, glenn, webkit | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=169308 https://bugs.webkit.org/show_bug.cgi?id=169307 |
||||||||
| Attachments: |
|
||||||||
|
Description
Srinivasan Vijayaraghavan
2017-02-28 11:30:58 PST
Created attachment 302955 [details]
Patch
Comment on attachment 302955 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302955&action=review looks good to me. > Tools/Scripts/webkitpy/tool/steps/runtests.py:168 > + self._tool.filesystem.maybe_make_directory(results_directory) do we need similar line in _run_javascriptcore_tests as well above. (In reply to comment #2) > Comment on attachment 302955 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=302955&action=review > > looks good to me. > > > Tools/Scripts/webkitpy/tool/steps/runtests.py:168 > > + self._tool.filesystem.maybe_make_directory(results_directory) > > do we need similar line in _run_javascriptcore_tests as well above. JSC tests cannot run without building, so if the WebKitBuild/[Release/Debug] directory doesn't exist at the time of writing the test results to a file, something would have gone very wrong. Adding the line enables some code to be abstracted out, but I'd prefer to not abstract things out until we have another group of tests. Some things, like the results directory, might change by then. Placing results inside WebKitBuild/ for consistency is OK, but it might make sense to move as we add more tests that don't require a build to run (bindings is one of them, also webkitpy, webkitperl etc). Created attachment 302982 [details]
Patch
Added a unit test. looks good to me. Comment on attachment 302982 [details] Patch Clearing flags on attachment: 302982 Committed r213185: <http://trac.webkit.org/changeset/213185> All reviewed patches have been landed. Closing bug. |