Bug 168955

Summary: Expose _WKVisitedLinkProvider in a header
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit2Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, mitz
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch none

Description Alexey Proskuryakov 2017-02-27 17:52:29 PST 
_WKVisitedLinkProvider should be in a header, because it is exported.
Comment 1 Alexey Proskuryakov 2017-02-27 17:55:06 PST 
Created attachment 302903 [details]
proposed patch
Comment 2 Aakash Jain 2017-02-27 18:01:53 PST 
Comment on attachment 302903 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302903&action=review

overall looks good to me.

> Source/WebKit2/UIProcess/API/Cocoa/_WKVisitedLinkStore.h:40
> +__attribute__((visibility("default"))) NS_UNAVAILABLE

why do we need NS_UNAVAILABLE?
Comment 3 Alexey Proskuryakov 2017-02-28 16:37:36 PST 
We don't want any new clients to use this function, it is only for binary compatibility.
Comment 4 WebKit Commit Bot 2017-02-28 17:05:54 PST 
Comment on attachment 302903 [details]
proposed patch

Clearing flags on attachment: 302903

Committed r213195: <http://trac.webkit.org/changeset/213195>
Comment 5 WebKit Commit Bot 2017-02-28 17:05:57 PST 
All reviewed patches have been landed.  Closing bug.