Bug 168941

Summary: [Modern Media Controls] Use a solid background for <audio> controls on macOS
Product: WebKit Reporter: Antoine Quint <graouts>
Component: MediaAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch for landing none

Antoine Quint
Reported 2017-02-27 15:31:35 PST
We should not use a background tint on macOS, but rather a solid fill.
Attachments
Patch (5.43 KB, patch)
2017-02-27 15:33 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.55 KB, patch)
2017-02-27 17:18 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-02-27 15:31:51 PST
<rdar://problem/30744316>
Antoine Quint
Comment 2 2017-02-27 15:33:15 PST
Created attachment 302877 [details] Patch
WebKit Commit Bot
Comment 3 2017-02-27 16:03:20 PST
Comment on attachment 302877 [details] Patch Clearing flags on attachment: 302877 Committed r213099: <http://trac.webkit.org/changeset/213099>
WebKit Commit Bot
Comment 4 2017-02-27 16:03:24 PST
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 5 2017-02-27 16:57:03 PST
The LayoutTest for this change is failing on iOS: https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/r213099%20(4127)/results.html It looks like ios-sim EWS caught this before the patch as landed.
Antoine Quint
Comment 6 2017-02-27 17:11:49 PST
Thanks Ryan, I'll fix this once I'm done building iOS.
Antoine Quint
Comment 7 2017-02-27 17:18:19 PST
Reopening to attach new patch.
Antoine Quint
Comment 8 2017-02-27 17:18:21 PST
Created attachment 302897 [details] Patch for landing
Ryan Haddad
Comment 9 2017-02-27 17:22:09 PST
Comment on attachment 302897 [details] Patch for landing Clearing flags on attachment: 302897 Committed r213106: <http://trac.webkit.org/changeset/213106>
Ryan Haddad
Comment 10 2017-02-27 17:22:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.