Bug 168934

Summary:

[mac-wk1] LayoutTest media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles.html is a flaky timeout

Product:

WebKit

Reporter:

Ryan Haddad <ryanhaddad>

Component:

New Bugs

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=170456

Attachments:

Description	Flags
Patch	none

Description Ryan Haddad 2017-02-27 14:25:25 PST

LayoutTest media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles.html is a flaky timeout

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r213089%20(4021)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fmacos-inline-media-controls%2Fmacos-inline-media-controls-buttons-styles.html

Comment 1 Radar WebKit Bug Importer 2017-03-01 19:11:02 PST

<rdar://problem/30798593>

Comment 2 Antoine Quint 2017-03-01 19:12:56 PST

Created attachment 303159 [details]
Patch

Comment 3 Dean Jackson 2017-03-01 19:15:36 PST

Comment on attachment 303159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303159&action=review

> LayoutTests/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-compact-buttons-styles.html:25
> +    [button, y] = buttonPositions[index];

Might take me a while to get used to this syntax.

Comment 4 WebKit Commit Bot 2017-03-01 20:36:52 PST

Comment on attachment 303159 [details]
Patch

Clearing flags on attachment: 303159

Committed r213261: <http://trac.webkit.org/changeset/213261>

Comment 5 WebKit Commit Bot 2017-03-01 20:36:56 PST

All reviewed patches have been landed.  Closing bug.