Bug 168934 - [mac-wk1] LayoutTest media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles.html is a flaky timeout
Summary: [mac-wk1] LayoutTest media/modern-media-controls/macos-inline-media-controls/...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-27 14:25 PST by Ryan Haddad
Modified: 2017-04-04 10:24 PDT (History)
3 users (show)

See Also:


Attachments
Patch (25.16 KB, patch)
2017-03-01 19:12 PST, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Radar WebKit Bug Importer 2017-03-01 19:11:02 PST
<rdar://problem/30798593>
Comment 2 Antoine Quint 2017-03-01 19:12:56 PST
Created attachment 303159 [details]
Patch
Comment 3 Dean Jackson 2017-03-01 19:15:36 PST
Comment on attachment 303159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303159&action=review

> LayoutTests/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-compact-buttons-styles.html:25
> +    [button, y] = buttonPositions[index];

Might take me a while to get used to this syntax.
Comment 4 WebKit Commit Bot 2017-03-01 20:36:52 PST
Comment on attachment 303159 [details]
Patch

Clearing flags on attachment: 303159

Committed r213261: <http://trac.webkit.org/changeset/213261>
Comment 5 WebKit Commit Bot 2017-03-01 20:36:56 PST
All reviewed patches have been landed.  Closing bug.