Bug 168928

Summary: [Win] REGRESSION(r211254): IWebPreferencesPrivate binary API broken
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 167421    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch bfulgham: review+

Brent Fulgham
Reported 2017-02-27 13:44:53 PST
Two new methods were injected into the existing IWebPreferencesPrivate interface, breaking binary API compatibility. We need to create a new IWebPreferencesPrivate5 interface holding these two new methods.
Attachments
Patch (2.88 KB, patch)
2017-02-28 09:23 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (3.52 KB, patch)
2017-02-28 09:41 PST, Per Arne Vollan 		bfulgham: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2017-02-27 13:45:56 PST
<rdar://problem/30687449>
Per Arne Vollan
Comment 2 2017-02-27 23:09:23 PST
It seems these methods were removed again in <http://trac.webkit.org/changeset/212173>.
Per Arne Vollan
Comment 3 2017-02-28 09:23:06 PST
Created attachment 302940 [details] Patch
Per Arne Vollan
Comment 4 2017-02-28 09:41:08 PST
Created attachment 302942 [details] Patch
Brent Fulgham
Comment 5 2017-02-28 10:50:50 PST
Comment on attachment 302942 [details] Patch R=me
Brent Fulgham
Comment 6 2017-02-28 10:52:01 PST
I think this is only relevant to the branch where this code is still present.
Brent Fulgham
Comment 7 2017-03-15 09:19:43 PDT
This was a branch-specific change.
Note You need to log in before you can comment on or make changes to this bug.