Bug 168928

Summary: [Win] REGRESSION(r211254): IWebPreferencesPrivate binary API broken
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 167421    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch bfulgham: review+

Description Brent Fulgham 2017-02-27 13:44:53 PST
Two new methods were injected into the existing IWebPreferencesPrivate interface, breaking binary API compatibility.

We need to create a new IWebPreferencesPrivate5 interface holding these two new methods.
Comment 1 Brent Fulgham 2017-02-27 13:45:56 PST
<rdar://problem/30687449>
Comment 2 Per Arne Vollan 2017-02-27 23:09:23 PST
It seems these methods were removed again in <http://trac.webkit.org/changeset/212173>.
Comment 3 Per Arne Vollan 2017-02-28 09:23:06 PST
Created attachment 302940 [details]
Patch
Comment 4 Per Arne Vollan 2017-02-28 09:41:08 PST
Created attachment 302942 [details]
Patch
Comment 5 Brent Fulgham 2017-02-28 10:50:50 PST
Comment on attachment 302942 [details]
Patch

R=me
Comment 6 Brent Fulgham 2017-02-28 10:52:01 PST
I think this is only relevant to the branch where this code is still present.
Comment 7 Brent Fulgham 2017-03-15 09:19:43 PDT
This was a branch-specific change.