Bug 168914

Summary: Add ability to configure JSC options from a file
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, fpizlo, keith_miller, mark.lam, saam
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
fpizlo: review+
Patch with build fixes.
none
Patch for landing - recoded the regex based JSC options white space removal code to walk through the string manually
none
Speculative build fix for Windows
none
Last try for a speculative windows build fix none

Michael Saboff
Reported 2017-02-27 09:47:52 PST
JavaScriptCore has various options to alter how it operates and enable various types of logging. These options can be set using command line options of the jsc command or via environment variables. It would be useful, especially for devices, to set options with a configuration file.
Attachments
Patch (31.16 KB, patch)
2017-02-27 10:38 PST, Michael Saboff 		fpizlo: review+
DetailsFormatted DiffDiff
Patch with build fixes. (31.73 KB, patch)
2017-02-27 11:21 PST, Michael Saboff 		no flags
DetailsFormatted DiffDiff
Patch for landing - recoded the regex based JSC options white space removal code to walk through the string manually (32.06 KB, patch)
2017-02-27 18:14 PST, Michael Saboff 		no flags
DetailsFormatted DiffDiff
Speculative build fix for Windows (32.20 KB, patch)
2017-02-27 20:55 PST, Michael Saboff 		no flags
DetailsFormatted DiffDiff
Last try for a speculative windows build fix (32.17 KB, patch)
2017-02-28 10:03 PST, Michael Saboff 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2017-02-27 09:48:57 PST
<rdar://problem/30735753>
Michael Saboff
Comment 2 2017-02-27 10:38:53 PST
Created attachment 302848 [details] Patch
WebKit Commit Bot
Comment 3 2017-02-27 10:41:32 PST
Attachment 302848 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/ConfigFile.cpp:101: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 4 2017-02-27 10:46:03 PST
Looks like there are build issues, but it looks sensible to me.
Mark Lam
Comment 5 2017-02-27 10:48:45 PST
I think you need some #pragmas to resolve the build warnings.
Mark Lam
Comment 6 2017-02-27 10:54:30 PST
(In reply to comment #5) > I think you need some #pragmas to resolve the build warnings. Oops .. I was looking at the GTK build failure, but you actually have other ones due to type conversion.
Michael Saboff
Comment 7 2017-02-27 11:21:55 PST
Created attachment 302856 [details] Patch with build fixes.
WebKit Commit Bot
Comment 8 2017-02-27 11:23:13 PST
Attachment 302856 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/ConfigFile.cpp:101: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Saboff
Comment 9 2017-02-27 18:14:44 PST
Created attachment 302906 [details] Patch for landing - recoded the regex based JSC options white space removal code to walk through the string manually
WebKit Commit Bot
Comment 10 2017-02-27 18:17:22 PST
Attachment 302906 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/ConfigFile.cpp:100: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Saboff
Comment 11 2017-02-27 20:55:20 PST
Created attachment 302920 [details] Speculative build fix for Windows
WebKit Commit Bot
Comment 12 2017-02-27 20:59:53 PST
Attachment 302920 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/ConfigFile.cpp:105: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Saboff
Comment 13 2017-02-28 10:03:33 PST
Created attachment 302944 [details] Last try for a speculative windows build fix
WebKit Commit Bot
Comment 14 2017-02-28 10:09:13 PST
Attachment 302944 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/ConfigFile.cpp:105: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Saboff
Comment 15 2017-02-28 10:51:53 PST
Committed r213151: <http://trac.webkit.org/changeset/213151>
Note You need to log in before you can comment on or make changes to this bug.