Bug 168877

Summary: Remove spurious C++ includes from WebKit2 SPI headers
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit2Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, mitz, sam
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix
mitz: review+, commit-queue: commit-queue-
Archive of layout-test-results from ews112 for mac-elcapitan none

Alexey Proskuryakov
Reported 2017-02-25 19:55:12 PST
There are some random unneeded includes.
Attachments
proposed fix (1.49 KB, patch)
2017-02-25 19:56 PST, Alexey Proskuryakov 		mitz: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews112 for mac-elcapitan (1.69 MB, application/zip)
2017-02-25 21:09 PST, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2017-02-25 19:56:23 PST
Created attachment 302769 [details] proposed fix
Build Bot
Comment 2 2017-02-25 21:09:56 PST
Comment on attachment 302769 [details] proposed fix Attachment 302769 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3194338 New failing tests: media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html
Build Bot
Comment 3 2017-02-25 21:09:59 PST
Created attachment 302773 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
WebKit Commit Bot
Comment 4 2017-02-26 16:19:15 PST
Comment on attachment 302769 [details] proposed fix Rejecting attachment 302769 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 302769, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: WebKit2/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit2/UIProcess/API/C/WKResourceLoadStatisticsManager.h Hunk #1 FAILED at 26. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit2/UIProcess/API/C/WKResourceLoadStatisticsManager.h.rej patching file Source/WebKit2/UIProcess/API/Cocoa/_WKTestingDelegate.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dan Bernstein']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3198576
Alexey Proskuryakov
Comment 5 2017-02-26 16:56:27 PST
Committed http://trac.webkit.org/r213021 (one of the changes was accidentally included in another patch that landed earlier).
Note You need to log in before you can comment on or make changes to this bug.