| Summary: | Text might wrap when its preferred logical width is used for sizing the containing block. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, koivisto, mmaxfield, simon.fraser, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2017-02-24 21:26:33 PST
Created attachment 302734 [details]
Patch
Alternative solutions are welcome! Comment on attachment 302734 [details] Patch Attachment 302734 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3189792 New failing tests: media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html Created attachment 302745 [details]
Archive of layout-test-results from ews112 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 302745 [details]
Archive of layout-test-results from ews112 for mac-elcapitan
Timeouts -> totally unrelated.
Comment on attachment 302734 [details] Patch Clearing flags on attachment: 302734 Committed r213008: <http://trac.webkit.org/changeset/213008> All reviewed patches have been landed. Closing bug. Comment on attachment 302734 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302734&action=review > Source/WebCore/platform/graphics/FontCascade.cpp:386 > + if (text.isNull() || text.isEmpty()) > + return 0; Checking isNull is redundant. If it's null, then it's also empty. |