Bug 168864 – Text might wrap when its preferred logical width is used for sizing the containing block.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

<rdar://problem/30690734>

[alan]

Created attachment 302734 [details]
Patch

[alan]

Alternative solutions are welcome!

[Build Bot]

Comment on attachment 302734 [details]
Patch

Attachment 302734 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3189792

New failing tests:
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html

[Build Bot]

Created attachment 302745 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[alan]

Comment on attachment 302745 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

Timeouts -> totally unrelated.

[WebKit Commit Bot]

Comment on attachment 302734 [details]
Patch

Clearing flags on attachment: 302734

Committed r213008: <http://trac.webkit.org/changeset/213008>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 302734 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302734&action=review

> Source/WebCore/platform/graphics/FontCascade.cpp:386
> +    if (text.isNull() || text.isEmpty())
> +        return 0;

Checking isNull is redundant. If it's null, then it's also empty.