Bug 168840

Summary: Media: notify clients when autoplay is denied
Product: WebKit Reporter: Matt Rajca <mrajca>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch achristensen: review+

Matt Rajca
Reported 2017-02-24 12:58:18 PST
Tell clients when autoplay is denied due to restrictions.
Attachments
Patch (23.73 KB, patch)
2017-02-24 13:02 PST, Matt Rajca 		achristensen: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matt Rajca
Comment 1 2017-02-24 13:02:17 PST
Created attachment 302680 [details] Patch
Alex Christensen
Comment 2 2017-02-24 13:49:50 PST
Comment on attachment 302680 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302680&action=review > Source/WebCore/html/HTMLMediaElement.cpp:2425 > + if (Page* page = document().page()) Darin would say "auto*" > Source/WebCore/page/AutoplayEvent.h:30 > +enum { I think we should make this enum class AutoplayEvent and cast it to uint32_t for IPC.
Matt Rajca
Comment 3 2017-02-24 15:08:51 PST
(In reply to comment #2) > Comment on attachment 302680 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=302680&action=review > > > Source/WebCore/html/HTMLMediaElement.cpp:2425 > > + if (Page* page = document().page()) > > Darin would say "auto*" > > > Source/WebCore/page/AutoplayEvent.h:30 > > +enum { > > I think we should make this enum class AutoplayEvent and cast it to uint32_t > for IPC. Done.
Matt Rajca
Comment 4 2017-02-27 08:46:48 PST
Committed: r212982
Note You need to log in before you can comment on or make changes to this bug.