Summary: | WebAssembly: validate load / store alignment | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | JF Bastien <jfbastien> | ||||
Component: | JavaScriptCore | Assignee: | JF Bastien <jfbastien> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | buildbot, commit-queue, fpizlo, jfbastien, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 159775 | ||||||
Attachments: |
|
Description
JF Bastien
2017-02-24 11:53:34 PST
Created attachment 309878 [details]
patch
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json". Comment on attachment 309878 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=309878&action=review r=me. with nit... maybe? > Source/JavaScriptCore/wasm/generateWasm.py:105 > + return str(int(math.log(memoryBits, 2))) nit: math.log doesn't return an int? O.o (In reply to Keith Miller from comment #4) > Comment on attachment 309878 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=309878&action=review > > r=me. with nit... maybe? > > > Source/JavaScriptCore/wasm/generateWasm.py:105 > > + return str(int(math.log(memoryBits, 2))) > > nit: math.log doesn't return an int? O.o No. Comment on attachment 309878 [details] patch Clearing flags on attachment: 309878 Committed r216908: <http://trac.webkit.org/changeset/216908> All reviewed patches have been landed. Closing bug. |