Bug 168832 – [iOS][WK2] Disable network cache speculative revalidation / loading in low power mode

• Component: WebKit2
• Status: RESOLVED FIXED

[Chris Dumez]

Disable network cache speculative revalidation / loading in low power mode on iOS to save battery.

[Radar WebKit Bug Importer]

<rdar://problem/30697911>

[Chris Dumez]

Created attachment 302676 [details]
Patch

[Antti Koivisto]

Comment on attachment 302676 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302676&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:85
> +                m_speculativeLoadManager = nullptr;

Have you verified that SpeculativeLoadManager can deal with being deleted while having ongoing requests? I think it is a new scenario. It could be tested with simulated repeated switches to low power and back while browsing.

[Chris Dumez]

(In reply to comment #3)
> Comment on attachment 302676 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=302676&action=review
> 
> > Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:85
> > +                m_speculativeLoadManager = nullptr;
> 
> Have you verified that SpeculativeLoadManager can deal with being deleted
> while having ongoing requests? I think it is a new scenario. It could be
> tested with simulated repeated switches to low power and back while browsing.

I'll try with simulated switches. I tried with manual ones but triggering them during a load is not super easy.

[Chris Dumez]

Comment on attachment 302676 [details]
Patch

Clearing flags on attachment: 302676

Committed r212965: <http://trac.webkit.org/changeset/212965>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.