Summary: | REGRESSION (r211312): Double-clicking a word selects it along with the space that follows it | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mitz | ||||||
Component: | WebKit2 | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, commit-queue, mitz, mmaxfield, thorton, webkit-bug-importer, wenson_hsieh | ||||||
Priority: | P1 | Keywords: | InRadar, Regression | ||||||
Version: | Safari Technology Preview | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
mitz
2017-02-23 21:19:28 PST
<rdar://problem/30690431> Caused by <https://trac.webkit.org/r211312>, the fix for bug 167530. Wenson Hsieh found the problem: “adding smartInsertDeleteEnabled to WebPageCreationParameters::encode and WebPageCreationParameters::decode fixes the problem for me”. Created attachment 302756 [details]
Patch
Comment on attachment 302756 [details]
Patch
Thanks Tim!
Comment on attachment 302756 [details] Patch Rejecting attachment 302756 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 302756, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: s/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj.rej patching file Tools/TestWebKitAPI/Tests/WebKit2Cocoa/double-click-does-not-select-trailing-space.html patching file Tools/TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm patching file Tools/TestWebKitAPI/cocoa/TestWKWebView.h patching file Tools/TestWebKitAPI/cocoa/TestWKWebView.mm Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Tim Horton']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3198114 Created attachment 302791 [details]
Patch for landing
Comment on attachment 302791 [details] Patch for landing Clearing flags on attachment: 302791 Committed r213012: <http://trac.webkit.org/changeset/213012> |