Bug 168808

Summary:

Web Inspector: RTL: add support for Styles - Visual sidebar

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED CONFIGURATION CHANGED

Severity:

Normal

CC:

bburg, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Image] Screenshot of Issue	none
Patch	none
[Image] After Patch is applied	none
Patch	none
[Image] After Patch is applied	none
Patch	bburg: review-

Devin Rousso

Reported 2017-02-23 16:21:07 PST

Created attachment 302603 [details] [Image] Screenshot of Issue .

Attachments
[Image] Screenshot of Issue (30.34 KB, image/png) 2017-02-23 16:21 PST, Devin Rousso	no flags	Details
Patch (53.25 KB, patch) 2017-02-24 16:06 PST, Devin Rousso	no flags	Details Formatted Diff Diff
[Image] After Patch is applied (60.60 KB, image/png) 2017-02-24 16:07 PST, Devin Rousso	no flags	Details
Patch (54.43 KB, patch) 2017-04-04 23:08 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
[Image] After Patch is applied (68.15 KB, image/png) 2017-04-04 23:09 PDT, Devin Rousso	no flags	Details
Patch (43.67 KB, patch) 2017-09-27 14:53 PDT, Devin Rousso	bburg: review-	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2017-02-24 16:06:59 PST

Created attachment 302697 [details] Patch

Devin Rousso

Comment 2 2017-02-24 16:07:28 PST

Created attachment 302698 [details] [Image] After Patch is applied

Blaze Burg

Comment 3 2017-02-24 22:17:36 PST

Comment on attachment 302697 [details] Patch Directions like left, right that are also CSS properties should not be flipped if used in a visual orientation where left is leftmost and right is rightmost. I see this in the screenshot for the absolute positioning offset properties and margin-left, padding-left, etc.

Radar WebKit Bug Importer

Comment 4 2017-04-02 09:48:33 PDT

<rdar://problem/31393671>

Devin Rousso

Comment 5 2017-04-04 23:08:40 PDT

Created attachment 306260 [details] Patch

Devin Rousso

Comment 6 2017-04-04 23:09:06 PDT

Created attachment 306261 [details] [Image] After Patch is applied

Blaze Burg

Comment 7 2017-04-05 11:29:54 PDT

(In reply to Devin Rousso from comment #6) > Created attachment 306261 [details] > [Image] After Patch is applied This is looking much better. I'll take it for a spin with Arabic localization to see if the editing makes sense. This sidebar is a bit of a grey area because some of the visual editors take CSS syntax as input which should always be LTR. Others are more direct-manipulation or wrap CSS values with UI, which is more open to RTL interpretation.

Devin Rousso

Comment 8 2017-09-27 14:53:32 PDT

Created attachment 322021 [details] Patch

Blaze Burg

Comment 9 2017-09-28 14:24:47 PDT

Comment on attachment 322021 [details] Patch I sent out some functional review comments via email with screenshots. When those are addressed I'll review the patch.

Devin Rousso

Comment 10 2018-10-25 01:28:26 PDT

The Visual styles sidebar was removed in r236298 <https://webkit.org/b/189807>.

Note You need to log in before you can comment on or make changes to this bug.