Bug 168807

Summary:

Web Inspector: RTL: Styles - Rules sidebar icons are misaligned

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, inspector-bugzilla-changes, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Image] Screenshot of Issue	none
Patch	bburg: review+, bburg: commit-queue-
[Image] After Patch is applied	none
Archive of layout-test-results from ews106 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews117 for mac-elcapitan	none
Patch	none

Devin Rousso

Reported 2017-02-23 15:55:09 PST

Created attachment 302597 [details] [Image] Screenshot of Issue .

Attachments
[Image] Screenshot of Issue (88.37 KB, image/png) 2017-02-23 15:55 PST, Devin Rousso	no flags	Details
Patch (9.67 KB, patch) 2017-02-23 16:18 PST, Devin Rousso	bburg: review+ bburg: commit-queue-	Details Formatted Diff Diff
[Image] After Patch is applied (98.03 KB, image/png) 2017-02-23 16:18 PST, Devin Rousso	no flags	Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.90 MB, application/zip) 2017-02-23 17:10 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-elcapitan (1.69 MB, application/zip) 2017-02-23 17:33 PST, Build Bot	no flags	Details
Patch (9.66 KB, patch) 2017-02-24 23:39 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2017-02-23 16:18:22 PST

Created attachment 302601 [details] Patch

Devin Rousso

Comment 2 2017-02-23 16:18:50 PST

Created attachment 302602 [details] [Image] After Patch is applied

Build Bot

Comment 3 2017-02-23 17:10:05 PST

Comment on attachment 302601 [details] Patch Attachment 302601 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3181917 New failing tests: media/modern-media-controls/volume-down-support/volume-down-support.html

Build Bot

Comment 4 2017-02-23 17:10:08 PST

Created attachment 302612 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 5 2017-02-23 17:33:01 PST

Comment on attachment 302601 [details] Patch Attachment 302601 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3181970 New failing tests: media/modern-media-controls/volume-down-support/volume-down-support.html

Build Bot

Comment 6 2017-02-23 17:33:03 PST

Created attachment 302617 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Blaze Burg

Comment 7 2017-02-24 22:05:34 PST

Comment on attachment 302601 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302601&action=review r=me > Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css:101 > + left: var(--style-declaration-section-header-icon-start); Nit: should be 'offset-start'. > Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css:139 > + margin: 4px var(--style-declaration-section-header-padding-end) 3px var(--style-declaration-section-header-padding-start); Please use a different variable specific to margins unless there is an arithmetic relation between the two. You can even define one in terms of the other if they must remain synced.

Devin Rousso

Comment 8 2017-02-24 23:39:03 PST

Created attachment 302743 [details] Patch

WebKit Commit Bot

Comment 9 2017-02-25 00:10:17 PST

Comment on attachment 302743 [details] Patch Clearing flags on attachment: 302743 Committed r212999: <http://trac.webkit.org/changeset/212999>

WebKit Commit Bot

Comment 10 2017-02-25 00:10:22 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.