Bug 168786

Summary: Ensure that the end of the last invalidation point does not extend beyond the end of the buffer.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, jfbastien, keith_miller, msaboff, saam
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
none
Archive of layout-test-results from ews116 for mac-elcapitan none

Description Mark Lam 2017-02-23 10:46:45 PST 
In practice, we will always have multiple instructions after invalidation points, and have enough room in the JIT buffer for the invalidation point to work with.  However, as a precaution, we can guarantee that there's enough room by always emitting a label just before we link the buffer.  The label will emit nop padding if needed.
Comment 1 Mark Lam 2017-02-23 10:50:26 PST 
Created attachment 302533 [details]
proposed patch.
Comment 2 Build Bot 2017-02-23 11:44:24 PST 
Comment on attachment 302533 [details]
proposed patch.

Attachment 302533 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3179795

New failing tests:
fast/dom/timer-throttling-hidden-page-non-nested.html
Comment 3 Build Bot 2017-02-23 11:44:28 PST 
Created attachment 302547 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 WebKit Commit Bot 2017-02-23 11:44:47 PST 
Comment on attachment 302533 [details]
proposed patch.

Clearing flags on attachment: 302533

Committed r212908: <http://trac.webkit.org/changeset/212908>
Comment 5 WebKit Commit Bot 2017-02-23 11:44:52 PST 
All reviewed patches have been landed.  Closing bug.