Bug 168785

Summary:

Add delegate method to handle images with alternate data.

Product:

WebKit

Reporter:

Yongjun Zhang <yongjun_zhang>

Component:

WebKit2

Assignee:

Yongjun Zhang <yongjun_zhang>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, bdakin, commit-queue, enrica, mitz, sam, thorton

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch.	none
Fix mac build.	buildbot: commit-queue-
Archive of layout-test-results from ews117 for mac-elcapitan	none
Address Dan's comment, adding two delegate methods (one for async and another for sync) to get alternate data.	none

Yongjun Zhang

Reported 2017-02-23 10:24:59 PST

It would be nice to have new UIDelegate methods to handle images with alternate data.

Attachments
Patch. (18.84 KB, patch) 2017-02-23 10:51 PST, Yongjun Zhang	no flags	Details Formatted Diff Diff
Fix mac build. (18.85 KB, patch) 2017-02-23 12:09 PST, Yongjun Zhang	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews117 for mac-elcapitan (1.69 MB, application/zip) 2017-02-23 15:47 PST, Build Bot	no flags	Details
Address Dan's comment, adding two delegate methods (one for async and another for sync) to get alternate data. (18.63 KB, patch) 2017-02-24 10:44 PST, Yongjun Zhang	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Yongjun Zhang

Comment 1 2017-02-23 10:25:55 PST

<rdar://problem/28776219>

Yongjun Zhang

Comment 2 2017-02-23 10:51:34 PST

Created attachment 302534 [details] Patch.

Yongjun Zhang

Comment 3 2017-02-23 12:09:59 PST

Created attachment 302554 [details] Fix mac build.

Build Bot

Comment 4 2017-02-23 15:47:19 PST

Comment on attachment 302554 [details] Fix mac build. Attachment 302554 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3181500 New failing tests: fast/dom/timer-throttling-hidden-page-non-nested.html

Build Bot

Comment 5 2017-02-23 15:47:22 PST

Created attachment 302593 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Yongjun Zhang

Comment 6 2017-02-24 10:44:47 PST

Created attachment 302673 [details] Address Dan's comment, adding two delegate methods (one for async and another for sync) to get alternate data.

Enrica Casucci

Comment 7 2017-02-28 13:00:30 PST

Comment on attachment 302673 [details] Address Dan's comment, adding two delegate methods (one for async and another for sync) to get alternate data. Looks good to me!

WebKit Commit Bot

Comment 8 2017-02-28 13:30:50 PST

Comment on attachment 302673 [details] Address Dan's comment, adding two delegate methods (one for async and another for sync) to get alternate data. Clearing flags on attachment: 302673 Committed r213170: <http://trac.webkit.org/changeset/213170>

WebKit Commit Bot

Comment 9 2017-02-28 13:30:54 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.