Bug 168783

Summary: Simple line layout: Adjust RunResolver::lineIndexForHeight with line struts.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

zalan
Reported 2017-02-23 09:50:28 PST
Struts push lines down so the lineIndex = y / m_lineHeight is not correct anymore.
Attachments
Patch (2.74 KB, patch)
2017-02-23 10:02 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (3.74 KB, patch)
2017-02-23 10:28 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-02-23 09:50:56 PST
<rdar://problem/30676449>
zalan
Comment 2 2017-02-23 10:02:32 PST
Created attachment 302525 [details] Patch
Antti Koivisto
Comment 3 2017-02-23 10:08:48 PST
Comment on attachment 302525 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302525&action=review > Source/WebCore/rendering/SimpleLineLayoutResolver.cpp:147 > + if (!m_layout.hasLineStruts()) > + return lineIndexCandidate; Could we factor the struts case to a function so that the common case stays clean? Something like if (m_layout.hasLineStruts()) return adjustLineIndexForStruts(lineIndexCandidate,...); return lineIndexCandidate;
zalan
Comment 4 2017-02-23 10:28:15 PST
Created attachment 302530 [details] Patch
WebKit Commit Bot
Comment 5 2017-02-23 11:27:05 PST
The commit-queue encountered the following flaky tests while processing attachment 302530 [details]: editing/spelling/spellcheck-async.html bug 160571 (authors: g.czajkowski@samsung.com and mark.lam@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2017-02-23 11:27:10 PST
The commit-queue encountered the following flaky tests while processing attachment 302530 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2017-02-23 12:13:40 PST
The commit-queue encountered the following flaky tests while processing attachment 302530 [details]: editing/spelling/spellcheck-async.html bug 160571 (authors: g.czajkowski@samsung.com and mark.lam@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2017-02-23 12:14:11 PST
Comment on attachment 302530 [details] Patch Clearing flags on attachment: 302530 Committed r212912: <http://trac.webkit.org/changeset/212912>
WebKit Commit Bot
Comment 9 2017-02-23 12:14:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.