Bug 168782 – [WebRTC][Mac][WebKit2] WebRTC requires media capture

• Component: Media
• Status: RESOLVED FIXED

[Eric Carlson]

WebRTC requires camera and microphone access, so always extend the web process sandbox to allow microphone access if WebRTC is enabled.

[Radar WebKit Bug Importer]

<rdar://problem/30675242>

[Eric Carlson]

Created attachment 302516 [details]
Proposed patch.

[youenn fablet]

Comment on attachment 302516 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=302516&action=review

> Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm:255
> +        webRTCEnabled = [defaults boolForKey:@"ExperimentalPeerConnectionEnabled"];

I am wondering whether we should add a comment here explaining why we are also checking webRTCEnabled here.

[Build Bot]

Comment on attachment 302516 [details]
Proposed patch.

Attachment 302516 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3179330

New failing tests:
media/modern-media-controls/volume-down-support/volume-down-support.html

[Build Bot]

Created attachment 302527 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 302516 [details]
Proposed patch.

Attachment 302516 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3179346

New failing tests:
media/modern-media-controls/volume-down-support/volume-down-support.html

[Build Bot]

Created attachment 302528 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 302516 [details]
Proposed patch.

Attachment 302516 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3179487

New failing tests:
editing/spelling/spellcheck-async.html

[Build Bot]

Created attachment 302531 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Eric Carlson]

Created attachment 302549 [details]
Patch for landing.

[WebKit Commit Bot]

Comment on attachment 302549 [details]
Patch for landing.

Clearing flags on attachment: 302549

Committed r212915: <http://trac.webkit.org/changeset/212915>