Bug 168752

Summary: Web Inspector: Add "goto arrow" to DOMNodeTreeElements in the Debugger tab
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 168101    
Bug Blocks:    
Attachments:
Description Flags
[Image] DOM node tree element UI
none
[Image] "Reveal in DOM tree"
none
Patch
none
Patch for landing none

Matt Baker
Reported 2017-02-22 16:00:16 PST
Created attachment 302457 [details] [Image] DOM node tree element UI See screenshot.
Attachments
[Image] DOM node tree element UI (94.54 KB, image/png)
2017-02-22 16:00 PST, Matt Baker 		no flags
Details
[Image] "Reveal in DOM tree" (132.82 KB, image/png)
2017-03-11 14:26 PST, Matt Baker 		no flags
Details
Patch (5.21 KB, patch)
2017-03-11 14:35 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.24 KB, patch)
2017-03-11 20:21 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2017-03-11 14:26:43 PST
Created attachment 304177 [details] [Image] "Reveal in DOM tree"
Matt Baker
Comment 2 2017-03-11 14:35:24 PST
Created attachment 304178 [details] Patch
Devin Rousso
Comment 3 2017-03-11 17:12:31 PST
Comment on attachment 304178 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304178&action=review > Source/WebInspectorUI/UserInterface/Views/DOMNodeTreeElement.js:54 > + contextMenu.appendSeparator(); > + contextMenu.appendItem(WebInspector.UIString("Reveal in DOM Tree"), () => { NIT: I think there should be a newline between these lines.
Matt Baker
Comment 4 2017-03-11 20:21:03 PST
Created attachment 304182 [details] Patch for landing
WebKit Commit Bot
Comment 5 2017-03-11 21:02:29 PST
Comment on attachment 304182 [details] Patch for landing Clearing flags on attachment: 304182 Committed r213765: <http://trac.webkit.org/changeset/213765>
WebKit Commit Bot
Comment 6 2017-03-11 21:02:33 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.