Summary: | [WebRTC] Add support for libwebrtc TCP incoming connections | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
Component: | WebCore Misc. | Assignee: | youenn fablet <youennf> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, commit-queue, eric.carlson | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
youenn fablet
2017-02-22 15:23:38 PST
Created attachment 302849 [details]
Patch
Attachment 302849 [details] did not pass style-queue:
ERROR: Source/WebKit2/NetworkProcess/webrtc/LibWebRTCSocketClient.h:52: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebKit2/NetworkProcess/webrtc/LibWebRTCSocketClient.h:70: The parameter name "socket" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebKit2/WebProcess/Network/webrtc/LibWebRTCSocket.h:51: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
Total errors found: 3 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 302849 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302849&action=review > Source/WebKit2/NetworkProcess/webrtc/LibWebRTCSocketClient.cpp:56 > + if (type == Type::ServerConnectionTCP) switch(type) > Source/WebKit2/WebProcess/Network/webrtc/WebRTCSocket.h:58 > + void signalNewConnection(uint64_t newSocketIdentifiert, const WebKit::RTCNetwork::SocketAddress&); Identifier Created attachment 302854 [details]
Patch for landing
Thanks for the review. (In reply to comment #3) > Comment on attachment 302849 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=302849&action=review > > > Source/WebKit2/NetworkProcess/webrtc/LibWebRTCSocketClient.cpp:56 > > + if (type == Type::ServerConnectionTCP) Done > switch(type) > > > Source/WebKit2/WebProcess/Network/webrtc/WebRTCSocket.h:58 > > + void signalNewConnection(uint64_t newSocketIdentifiert, const WebKit::RTCNetwork::SocketAddress&); > > Identifier Done Created attachment 302864 [details]
Patch for landing
Comment on attachment 302864 [details] Patch for landing Clearing flags on attachment: 302864 Committed r213104: <http://trac.webkit.org/changeset/213104> All reviewed patches have been landed. Closing bug. |