Bug 168746

Summary:

Web Inspector: RTL: Elements tab Styles sidebar label/arrows need adjustment

Product:

WebKit

Reporter:

Matt Baker <mattbaker>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Image] Styles arrow glyph spacing	none
Patch	bburg: review+
[Image] After Patch is applied	none
Patch	commit-queue: commit-queue-
Patch	none

Matt Baker

Reported 2017-02-22 14:48:19 PST

Created attachment 302448 [details] [Image] Styles arrow glyph spacing This was fixed for navigation sidebars, but details sidebars are broken.

Attachments
[Image] Styles arrow glyph spacing (99.99 KB, image/png) 2017-02-22 14:48 PST, Matt Baker	no flags	Details
Patch (3.24 KB, patch) 2017-02-23 15:51 PST, Devin Rousso	bburg: review+	Details Formatted Diff Diff
[Image] After Patch is applied (19.76 KB, image/png) 2017-02-23 15:52 PST, Devin Rousso	no flags	Details
Patch (3.07 KB, patch) 2017-02-24 23:34 PST, Devin Rousso	commit-queue: commit-queue-	Details Formatted Diff Diff
Patch (3.14 KB, patch) 2017-02-25 00:20 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2017-02-23 15:51:52 PST

Created attachment 302595 [details] Patch

Devin Rousso

Comment 2 2017-02-23 15:52:34 PST

Created attachment 302596 [details] [Image] After Patch is applied

Blaze Burg

Comment 3 2017-02-24 22:00:37 PST

Comment on attachment 302595 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302595&action=review r=me > Source/WebInspectorUI/UserInterface/Views/ScopeRadioButtonNavigationItem.css:29 > + --scope-radio-button-navigation-item-select-start: 0; NIt: should say 'offset-start' if using CSS property 'left' in LTR.

Devin Rousso

Comment 4 2017-02-24 23:34:10 PST

Created attachment 302742 [details] Patch

WebKit Commit Bot

Comment 5 2017-02-25 00:07:21 PST

Comment on attachment 302742 [details] Patch Rejecting attachment 302742 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 302742, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: : Uncaught Exception: Unknown angle units "undefined" The copy of the patch that failed is found in: /Volumes/Data/EWS/WebKit/.git/rebase-apply/patch When you have resolved this problem, run "git rebase --continue". If you prefer to skip this patch, run "git rebase --skip" instead. To check out the original branch and stop rebasing, run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at /Volumes/Data/EWS/WebKit/Tools/Scripts/webkitdirs.pm line 2607. Full output: http://webkit-queues.webkit.org/results/3189993

Devin Rousso

Comment 6 2017-02-25 00:20:23 PST

Created attachment 302749 [details] Patch

WebKit Commit Bot

Comment 7 2017-02-25 00:45:18 PST

Comment on attachment 302749 [details] Patch Clearing flags on attachment: 302749 Committed r213001: <http://trac.webkit.org/changeset/213001>

WebKit Commit Bot

Comment 8 2017-02-25 00:45:22 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.