Bug 168732

Summary:

Move instance members from WebSelectionRect.h to implementation file

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

WebKit Misc.

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, juergen, mitz, thorton

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none
Updated patch	thorton: review+, thorton: commit-queue-
Updated patch	none

Aakash Jain

Reported 2017-02-22 10:42:24 PST

There are few symbols in WebSelectionRect interface in WebKit/ios/WebCoreSupport/WebSelectionRect.h and are not exported. We should export these symbols so that the headers matches with the library.

Attachments
Proposed patch (1.32 KB, patch) 2017-02-22 10:44 PST, Aakash Jain	no flags	Details Formatted Diff Diff
Updated patch (2.02 KB, patch) 2017-02-22 13:01 PST, Aakash Jain	thorton: review+ thorton: commit-queue-	Details Formatted Diff Diff
Updated patch (2.22 KB, patch) 2017-02-22 13:51 PST, Aakash Jain	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2017-02-22 10:44:05 PST

Created attachment 302413 [details] Proposed patch

Tim Horton

Comment 2 2017-02-22 10:56:06 PST

If they're not exported, does that mean that nobody is using them, so maybe they shouldn't be in the header?

Aakash Jain

Comment 3 2017-02-22 11:01:52 PST

Yes, I believe that's another option. I'm not sure which option is better.

Alexey Proskuryakov

Comment 4 2017-02-22 11:11:53 PST

This seems like an issue for many classes. Even for those that hide instance variables in _private, we still have to export _private. I wonder if there is a better way to explain to the toolchain that private instance variables don't need symbols exported for them.

Tim Horton

Comment 5 2017-02-22 11:53:03 PST

(In reply to comment #4) > This seems like an issue for many classes. Even for those that hide instance > variables in _private, we still have to export _private. > > I wonder if there is a better way to explain to the toolchain that private > instance variables don't need symbols exported for them. Can we not move instance members to the implementation for iOS-only files (can't do it for things built on Mac because of the modern runtime), for some reason? Then, do we have to export anything?

Aakash Jain

Comment 6 2017-02-22 13:01:13 PST

Created attachment 302427 [details] Updated patch

Aakash Jain

Comment 7 2017-02-22 13:02:23 PST

(In reply to comment #5) > Can we not move instance members to the implementation for iOS-only files > (can't do it for things built on Mac because of the modern runtime), for > some reason? Then, do we have to export anything? Yes, I believe that would be clean approach. Patch updated.

Tim Horton

Comment 8 2017-02-22 13:26:40 PST

Comment on attachment 302427 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=302427&action=review > Source/WebKit/ios/WebCoreSupport/WebSelectionRect.h:32 > @interface WebSelectionRect : NSObject <NSCopying> { All of the comments from bug 168705 apply here too!

Aakash Jain

Comment 9 2017-02-22 13:51:41 PST

Created attachment 302437 [details] Updated patch remove extra {} and added ivars to @implementation.

WebKit Commit Bot

Comment 10 2017-02-22 15:14:46 PST

Comment on attachment 302437 [details] Updated patch Clearing flags on attachment: 302437 Committed r212856: <http://trac.webkit.org/changeset/212856>

WebKit Commit Bot

Comment 11 2017-02-22 15:14:50 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.